Apply cs #532
Merged
Apply cs #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
reviewed
Mar 13, 2020
| private $locales; | ||
|
|
||
| public function __construct(ConfigFactory $configFactory, Updater $updater, array $locales) | ||
| { | ||
| $this->configFactory = $configFactory; | ||
| $this->updater = $updater; | ||
| $this->locales = $locales; | ||
| $this->updater = $updater; |
There was a problem hiding this comment.
i remember having disabled this in jms serializer...
There was a problem hiding this comment.
You're right, I missed some excluded rules
|
thanks |
ViniTou
reviewed
Mar 17, 2020
| @@ -1,5 +1,7 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This are the changes of applying Doctrine coding standards to the whole code. I tried to manually check the code looking for some calls (that could fail with
strict_types), but maybe I'm missing some.